Michael Pasternak has posted comments on this change. Change subject: cli: Ping command success message need to be rephrased(#918749) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File src/cli/messages.py Line 61: ACTION_STATUS = 'action status "%s".' Line 62: STATUS = '\nlast command status: %s' Line 63: PRODUCT_VERSION = "\n%s version: %s.\n" Line 64: NOT_CONNECTED = 'not connected.' Line 65: SUCESS_CONNECT_TO_BACKEND = '\noVirt manager could be reached successfully.\n\n' i think Oded wanted s/oVirt/RHEVM Line 66: SDK_VERSION = 'sdk version : %s' Line 67: CLI_VERSION = 'cli version : %s' Line 68: BACKEND_VERSION = 'backend version: %s' Line 69: BACKEND_ENTRY_POINT = 'entry point : %s' -- To view, visit http://gerrit.ovirt.org/12840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9db7fa5c022713448674f4204470a7c502a1cfe5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
