Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 92:
Line 93: VM vm = getVm();
Line 94:
Line 95: if (vm != null) {
Line 96: updateDisksFromDb();
You are mistaken.
This was extracted from isDiksCanBeAddToVm (see change in
AbstractDiskVmCommand), so there is in fact no functional change.
As to the reasoning behind it - this is required for the validation in that
function.
Line 97: // if user sent drive check that its not in use
Line 98: if (!isDiskCanBeAddedToVm(getParameters().getDiskInfo()) ||
Line 99:
!isDiskPassPciAndIdeLimit(getParameters().getDiskInfo())) {
Line 100: return false;
--
To view, visit http://gerrit.ovirt.org/12896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
