Allon Mureinik has posted comments on this change.
Change subject: core: UpdateVmDiskCommand - synthetic access warn
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 282: }
Line 283: return jobProperties;
Line 284: }
Line 285:
Line 286: private boolean isQuotaValidationNeeded() {
I prefer leaving whatever I can private, as long as it doesn't generate a
warning.
Line 287: return oldDisk != null && newDisk != null && oldDisk
instanceof DiskImage &&
Line 288: newDisk instanceof DiskImage && DiskStorageType.IMAGE
== oldDisk.getDiskStorageType();
Line 289: }
Line 290:
--
To view, visit http://gerrit.ovirt.org/12885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07ed8b37f4c22807b8981959b7b03d7baa19de68
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
