Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Added caching ......................................................................
Patch Set 15: Verified Final version of the patch, there's now only one Frontend JAR (to rule them all), with commons-logging's servlet API exclusion done in frontend/webadmin/modules/pom.xml Verified in FF10/Linux and IE8/WinXP. Note: JBoss currently doesn't trim whitespace away from JSPs, so rendering GwtHostPage.jsp causes some whitespace to appear *before* HTML DOCTYPE declaration (this didn't happen before this patch, since we constructed HTML response directly within the servlet). I verified both applications in IE8/WinXP and didn't see any issues, though. PS: it's possible to control whitespace trimming in JBoss AS7 [http://docs.jboss.org/jbossweb/7.0.x/config/jsp.html], but this support is broken in 7.1.1.Final [https://issues.jboss.org/browse/AS7-4187]. -- To view, visit http://gerrit.ovirt.org/10449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d8e02ae542a4aa37bd421bde5582c0f3e9820ad Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
