Juan Hernandez has uploaded a new change for review.

Change subject: core: Change LocalConfig log level to debug
......................................................................

core: Change LocalConfig log level to debug

The engine-config tool uses a console appender, and that means that the
info log messages generated by the LocalConfig class end up in the
console, mixed with the regular output of the tool. The right way to fix
that should be to not use the console appender, but that would probably
break engine-config, as it uses it for regular output. This patch
changes the log level of LocalConfig to debug, to avoid the issue.

Change-Id: Iad3a844771cfa6facc9e55b39a54781b4045d982
Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com>
---
M 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/12795/1

diff --git 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
index fe72236..c46fa37 100644
--- 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
+++ 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
@@ -112,17 +112,15 @@
             }
         }
 
-        // Dump the properties to the log (this should probably be DEBUG, but 
as
-        // it will usually happen only once, during the startup, is not that a
-        // problem to use INFO):
-        if (log.isInfoEnabled()) {
+        // Dump the properties to the log:
+        if (log.isDebugEnabled()) {
             Set<String> keys = values.keySet();
             List<String> list = new ArrayList<String>(keys.size());
             list.addAll(keys);
             Collections.sort(list);
             for (String key : list) {
                 String value = values.get(key);
-                log.info("Value of property \"" + key + "\" is \"" + value + 
"\".");
+                log.debug("Value of property \"" + key + "\" is \"" + value + 
"\".");
             }
         }
     }
@@ -149,7 +147,7 @@
             while ((line = reader.readLine()) != null) {
                 loadLine(line);
             }
-            log.info("Loaded file \"" + file.getAbsolutePath() + "\".");
+            log.debug("Loaded file \"" + file.getAbsolutePath() + "\".");
         }
         catch (IOException exception) {
             log.error("Can't load file \"" + file.getAbsolutePath() + "\".", 
exception);


--
To view, visit http://gerrit.ovirt.org/12795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad3a844771cfa6facc9e55b39a54781b4045d982
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to