Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix vm pop-up host tab logic
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
all Daniel's comments were addressed
acking
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1755: }
Line 1756: }
Line 1757:
Line 1758: public void setMigrationMode(MigrationSupport value) {
Line 1759: getMigrationMode().setSelectedItem(value);
this method could be removed... could be done in a later patch.
Line 1760: }
Line 1761:
Line 1762: public void SetDataCenter(UnitVmModel model,
ArrayList<storage_pool> list)
Line 1763: {
--
To view, visit http://gerrit.ovirt.org/12706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4da1be4919913b7739f4139299d2c88958488d0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000369
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
