Allon Mureinik has posted comments on this change. Change subject: WIP core: fix businessentity hashCode/equals errors ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 23: Misc: Line 24: VmDevice (possible NPE, also in toString()) Line 25: Line 26: DO NOT MERGE! Some of the changes above need closer inspection before Line 27: merging, and some of the changes will cause unit tests to fail. I suggest you mark the patch as fails, just in case Line 28: Line 29: Discussion points found so far: Line 30: - changing VmBase causes the OvfManager import/export unit tests to Line 31: fail because the domain and timeZone fields are transformed from -- To view, visit http://gerrit.ovirt.org/12539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83c16ab9bbbb95f45bfcd91920f8137890e63d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
