Omer Frenkel has posted comments on this change.

Change subject: engine: avoid passing userId in User queries
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java
Line 26:         }
Line 27:         if (isSucceeded) {
Line 28:             queryResult =
Line 29:                     
Backend.getInstance().runInternalQuery(VdcQueryType.GetAllVmPoolsAttachedToUser,
Line 30:                             new VdcQueryParametersBase());
i thought i happens automatically in the backend class, but looking at it now 
it seems that this code is not performed for internal execution, do you know 
why?
Line 31:             if (queryResult != null && queryResult.getSucceeded()) {
Line 32:                 retValList.addAll((List<VmPool>) 
queryResult.getReturnValue());
Line 33:             } else {
Line 34:                 isSucceeded = false;


--
To view, visit http://gerrit.ovirt.org/12458
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to