Kiril Nesenko has posted comments on this change.
Change subject: tools: fixed command line parser setup
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File src/__main__.py
Line 67: raise Exception("Error: unknown value type '%s' was requested"
% \
Line 68: dbconf_param)
Line 69: inDbAdminSection = False
Line 70: if (os.path.exists(FILE_PG_PASS)):
Line 71: logging.debug("found existing pgpass file, fetching DB %s
value" % \
"Found ...
Line 72: dbconf_param)
Line 73: with open(FILE_PG_PASS) as pgPassFile:
Line 74: for line in pgPassFile:
Line 75:
Line 104: pg_user = get_pg_var('admin') or pg_user
Line 105: pg_pass = get_pg_var('pass', pg_user) or pg_pass
Line 106: pg_dbhost = get_pg_var('host') or pg_dbhost
Line 107: pg_dbport = get_pg_var('port') or pg_dbport
Line 108: except Exception as e:
Is it ok to catch Exception and not the specific one ?
Line 109: print "Warning: error while reading .pgpass configuration:
%s" % str(e)
Line 110: ExitCodes.exit_code = ExitCodes.WARN
Line 111:
Line 112:
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
