Eli Mesika has posted comments on this change. Change subject: engine: Manage Gluster hooks support ......................................................................
Patch Set 22: (2 inline comments) .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 27: Line 28: Line 29: Line 30: Create or replace FUNCTION GetGlusterHookById(v_id UUID, Line 31: v_includeContent BOOLEAN=false) The correct way to do that is to create a view with those columns and a new SP that selects * from that view Line 32: RETURNS SETOF gluster_hooks Line 33: AS $procedure$ Line 34: BEGIN Line 35: if (v_includeContent = true) then Line 74: Create or replace FUNCTION GetGlusterHook(v_cluster_id UUID, Line 75: v_gluster_command VARCHAR(1000), Line 76: v_stage VARCHAR(100), Line 77: v_name VARCHAR(1000), Line 78: v_includeContent BOOLEAN=false) same comment, see above Line 79: RETURNS SETOF gluster_hooks Line 80: AS $procedure$ Line 81: BEGIN Line 82: if (v_includeContent = true) then -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
