Alexander Wels has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTreeView.java
Line 100: table.setRowData(new ArrayList<EntityModel>());
Line 101: // Since tree views don't have an 'emptyTreeWidget to
display, we will
Line 102: // use the fact that we are using a table to display the
'header' to have
Line 103: // it display the no items to display message.
Line 104: if (sender instanceof ListModel) {
I prefer to check a particular type before casting to it. Heck Findbugs might
even flag this as a problem if we don't.
Line 105: ListModel model = (ListModel) sender;
Line 106: if (model.getItems() == null || ((List<M>)
model.getItems()).isEmpty()) {
Line 107: table.setEmptyTableWidget(new
NoItemsLabel(model.getTitle()));
Line 108: } else {
--
To view, visit http://gerrit.ovirt.org/12738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I508cf4c9ca61ceb58d4647d3074ae7638a8adcd6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
