Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Fix FindBugs warning in AbstractActionTable
......................................................................
webadmin,userportal: Fix FindBugs warning in AbstractActionTable
FindBugs reports a false-positive "impossible cast" warning
in AbstractActionTable.getTableHeaderCells() method, since
CellTable.getElement() method always returns TableElement at
runtime.
This patch fixes the above mentioned warning.
Change-Id: Id53a2306d8d737c42f24d9093899a764319b0c2b
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/12710/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
index d89a325..6d46eb4 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
@@ -443,7 +443,8 @@
List<TableCellElement> getTableHeaderCells(int columnIndex) {
Element tableHeaderElement = showDefaultHeader ? table.getElement() :
tableHeader.getElement();
- TableSectionElement tHeadElement = ((TableElement)
tableHeaderElement).getTHead();
+ TableElement tableHeaderElementCast = tableHeaderElement.cast();
+ TableSectionElement tHeadElement = tableHeaderElementCast.getTHead();
return tHeadElement != null ? getCells(tHeadElement.getRows(),
columnIndex)
: Collections.<TableCellElement> emptyList();
}
--
To view, visit http://gerrit.ovirt.org/12710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id53a2306d8d737c42f24d9093899a764319b0c2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
