Itamar Heim has posted comments on this change.

Change subject: Trusted Compute Pools - Open Attestation integration with oVirt 
engine proposal
......................................................................


Patch Set 3: (1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-01-19 05:23:18 -0500
Line 4: Commit:     Dave Chen <[email protected]>
Line 5: CommitDate: 2013-02-27 05:17:53 -0500
Line 6: 
Line 7: Trusted Compute Pools - Open Attestation integration with oVirt engine 
proposal
actually, doron comments is better:
"Hi Dave, although a step forward I still do not see the documented design for 
this patch. Am I missing something? I recommend you follow 
http://gerrit.ovirt.org/#/c/9023/ as a good example how such changes should be 
introduced.

Additionally, Several comments from previous patch version are being 
disregarded. I'd assume the comments to be implemented if no good reason why 
not to implement them.

Thanks! Doron"
Line 8: 
Line 9: Change-Id: I4de780cd46069638433255f3f9c994575f752e55


--
To view, visit http://gerrit.ovirt.org/11237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4de780cd46069638433255f3f9c994575f752e55
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to