Einav Cohen has posted comments on this change. Change subject: core: Removed GetTagIdsAndChildrenIdsByRegExp refs ......................................................................
Patch Set 1: Allon - question, just out of curiosity: AFAIR, this query has been used internally as part of the search mechanism. e.g. if I have a tag "Israel", and sub-tags "TLV" and "Jerusalem", and I am searching "VM: tag = "Isra*", the search query mechanism was(/is) using the GetTagIdsAndChildrenIdsByRegExp query, which accepts "Isra*" as a parameter, and return the following result: { [Israel-tag-id], [Jerusalem-tag-id], [TLV-tag-id] } this result would have then be used by the search query mechanism to build the relevant part of the SQL query (e.g. "... and tagID contains { tag-id1, tag-id2, ...} ..." or something similar). So IIUC: The GetTagIdsAndChildrenIdsByRegExp is not used by the search mechanism anymore? and I assume that there is another solution for the search example that I detailed above? -- To view, visit http://gerrit.ovirt.org/12601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7a7ab04a5c1a9fc1104d0ddb2d3a3a8ec0f1e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches