Daniel Erez has posted comments on this change.
Change subject: webadmin: Cleanup of AdElementListModel constructor
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
Line 211: }
Line 212: }
Line 213: }
Line 214:
Line 215: Collections.sort(roles, new Comparator<Role>() {
use RoleNameComparer
Line 216: @Override
Line 217: public int compare(Role left, Role right) {
Line 218: return left.getname().compareTo(right.getname());
Line 219: }
Line 223: if (selectedRole != null) {
Line 224: getRole().setSelectedItem(selectedRole);
Line 225: } else if (roles.size() > 0){
Line 226: //if engine user does not exist, pick the first on the
list
Line 227: getRole().setSelectedItem(roles.get(0));
is it a new logic? why is it needed? (comment from previous patch...)
Line 228: }
Line 229: }
Line 230:
Line 231: @Override
--
To view, visit http://gerrit.ovirt.org/12667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacc5878f32f5b5395dd5a87a0614b4c3a21bf88d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
