Alon Bar-Lev has posted comments on this change.

Change subject: Added logging of insufficient local space
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File src/__main__.py
Line 1215:                             size_needed_mb = "%1.f" % \
Line 1216:                                 (float(ovf_file_size) / float(pow(2, 
20)))
Line 1217:                             logging.error(_(
Line 1218:                                 "Not enough space in {tempdir}:"
Line 1219:                                 " {size_needed} Mb are 
needed.").format(
No space between number and unit...
Line 1220:                                     tempdir=tempfile.gettempdir(),
Line 1221:                                     size_needed=size_needed_mb
Line 1222:                                 )
Line 1223:                             )


--
To view, visit http://gerrit.ovirt.org/12688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to