Eli Mesika has posted comments on this change.
Change subject: core: no quota refresh when vm stopped
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 35: private static HashMap<Guid, Map<Guid, Quota>> storagePoolQuotaMap
= new HashMap<Guid, Map<Guid, Quota>>();
Line 36:
Line 37: private static final QuotaManagerAuditLogger
quotaManagerAuditLogger = new QuotaManagerAuditLogger();
Line 38: private final List<QuotaConsumptionParameter> corruptedParameters
= new ArrayList<QuotaConsumptionParameter>();
Line 39: private static Map<Integer, Integer>
nonCountableQutoaVmStatusesMap = new HashMap<Integer, Integer>();
1) should be final
2) please consider using synchronized Map
Line 40:
Line 41: public static QuotaManager getInstance() {
Line 42: return INSTANCE;
Line 43: }
--
To view, visit http://gerrit.ovirt.org/12014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2bd42a8431325ddbe552363b299fb80dbd7f3c5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
