Liron Aravot has uploaded a new change for review. Change subject: core: DeactivateStorageDomain - allow unknown status if executed as internal ......................................................................
core: DeactivateStorageDomain - allow unknown status if executed as internal When the deactivate storage domain command is executed as internal command, allow deactivating when the domain status is unknown - this is required so that domain failover process will be able to deactivate domains also if their status is unknown. Change-Id: I6e84a6ce8bf81d263c7466d1e99ed4233e16e1ad related to Bug-Url: https://bugzilla.redhat.com/912054 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/12686/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java index d7e7f35..a501ed3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java @@ -77,7 +77,13 @@ @Override protected boolean canDoAction() { - if (!(checkStorageDomain() && checkStorageDomainStatus(StorageDomainStatus.Active))) { + if (!(checkStorageDomain())) { + return false; + } + + // when the execution is internal, proceed also if the domain is in unknown status. + if (!((getParameters().getIsInternal() && checkStorageDomainStatus(StorageDomainStatus.Active, + StorageDomainStatus.Unknown)) || checkStorageDomainStatus(StorageDomainStatus.Active))) { return false; } -- To view, visit http://gerrit.ovirt.org/12686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e84a6ce8bf81d263c7466d1e99ed4233e16e1ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
