Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove PerformImagesChecks from AddDisk
......................................................................
core: Remove PerformImagesChecks from AddDisk
Several previous patches have removed checks not related to DiskImages
from PerformImagesChecks (The last one being change id
I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4, that removed storage domain
validation).
Now, since PerformImagesChecks only checks DiskImages, passing an
emptyList() to it is meaningless, and can safely be removed.
Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/12641/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
index 8fbd688..45aa135 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
@@ -144,7 +144,6 @@
returnValue =
validate(new StoragePoolValidator(sp).isUp()) &&
isStoragePoolMatching(vm) &&
- performImagesChecks(vm.getStoragePoolId()) &&
validate(getSnapshotValidator().vmNotDuringSnapshot(vm.getId())) &&
validate(getSnapshotValidator().vmNotInPreview(vm.getId())) &&
validate(new VmValidator(vm).vmNotLocked());
@@ -193,17 +192,6 @@
getStorageDomain().getStorageStaticData(),
getDiskImageInfo(),
getReturnValue().getCanDoActionMessages());
- }
-
- protected boolean performImagesChecks(Guid spId) {
- return ImagesHandler.PerformImagesChecks(
- getReturnValue().getCanDoActionMessages(),
- spId,
- true,
- false,
- false,
- false,
- Collections.<DiskImage> emptyList());
}
private double getRequestDiskSpace() {
--
To view, visit http://gerrit.ovirt.org/12641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
