Alona Kaplan has posted comments on this change.
Change subject: webadmin: Improved Comparable implementation of NetworkItemModel
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkItemModel.java
Line 26: }
Line 27:
Line 28: @Override
Line 29: public int compareTo(NetworkItemModel<T> o) {
Line 30: return LexoNumericComparator.comp(getName(), o.getName());
I couldn't find a use to the compareTo. I think you can remove it.
Line 31: }
Line 32:
Line 33: public String getError() {
Line 34: return error;
--
To view, visit http://gerrit.ovirt.org/12001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e70d34f5dcd30ed85e898cd3bb0c47a6f4f7a9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
