Allon Mureinik has posted comments on this change. Change subject: webadmin: DiskModel - naming convention cleanup ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 9: DiskModel: Line 10: * Renamed variable names (Java conventions). Line 11: * Reorganized variables getters/setters (and remove redundant). Line 12: * Removed redundant call to deprecated GetDiskPresetList. Line 13: (removed GetDiskPresetList from AsyncDataProvider). I think this change should be done in a separate patch, not as part of a renaming patch, which is massive as is Line 14: Line 15: Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0 -- To view, visit http://gerrit.ovirt.org/12579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
