Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixed sorting of bonds in create bond popup
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 444: return;
Line 445: }
Line 446: bondPopup.getBond().setItems(freeBonds);
Line 447:
Line 448: Collections.sort(freeBonds, new
Comparator<VdsNetworkInterface>() {
If there is no explicit setItems() you can add it (override it).
That is not accurate, it does matter. For hosts in cluster 3.0 or beneath you
don't have a setup networks dialog, you create bond form the host->interfaces
subtab.
Line 449:
Line 450: LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 451:
Line 452: @Override
--
To view, visit http://gerrit.ovirt.org/12154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief91fe080d1642d25eca43be9506250892ce746b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
