Arik Hadas has posted comments on this change.
Change subject: frontend: VM Linux Boot options aren't parsing properly
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 602:
Line 603: boolean customPropertyValidation =
getCustomPropertySheet().validate();
Line 604:
Line 605: if (getIsLinux_Unassign_UnknownOS()) {
Line 606: // trimming check
IMO the following code is self-explanatory, so no need for this comment
Line 607: getKernel_path().ValidateEntity(new IValidation[] { new
NoTrimmingWhitespacesValidation() });
Line 608: getInitrd_path().ValidateEntity(new IValidation[] { new
NoTrimmingWhitespacesValidation() });
Line 609: getKernel_parameters().ValidateEntity(new IValidation[] {
new NoTrimmingWhitespacesValidation() });
Line 610:
--
To view, visit http://gerrit.ovirt.org/12494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23bd3ee3677c9bdbfacf1cf341dc1d97fd57c65e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
