Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: In case of copy/pasted logic with small differences, won't it be simpler to design class inheritance hierarchy to the Model itself? I guess that most of the specific builders probably won't be used several times, so introducing numerous small builders might be confusing. Not sure regarding the new Instance Types implementation, I just don't think it's necessarily the appropriate convention for the entire uicommon infrastructure. -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
