Arik Hadas has uploaded a new change for review. Change subject: restapi: remove duplicate "implements" statements ......................................................................
restapi: remove duplicate "implements" statements Remove "implements ReadOnlyDevicesResource" statements from classes that extend AbstractBackendReadOnlyDevicesResource which is already set to implement the ReadOnlyDevicesResource interface. Change-Id: I0388f7941e845d722fd26486a27fe35880792aa3 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java 3 files changed, 5 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/12535/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java index 2485475..9152ec8 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyCdRomsResource.java @@ -1,18 +1,16 @@ package org.ovirt.engine.api.restapi.resource; +import static org.ovirt.engine.api.restapi.types.CdRomMapper.CDROM_ID; + import org.ovirt.engine.api.model.CdRom; import org.ovirt.engine.api.model.CdRoms; -import org.ovirt.engine.api.resource.ReadOnlyDevicesResource; import org.ovirt.engine.core.common.businessentities.IVdcQueryable; import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; import org.ovirt.engine.core.common.queries.VdcQueryType; import org.ovirt.engine.core.compat.Guid; -import static org.ovirt.engine.api.restapi.types.CdRomMapper.CDROM_ID; - public class BackendReadOnlyCdRomsResource<Q extends IVdcQueryable> - extends AbstractBackendReadOnlyDevicesResource<CdRom, CdRoms, Q> - implements ReadOnlyDevicesResource<CdRom, CdRoms> { + extends AbstractBackendReadOnlyDevicesResource<CdRom, CdRoms, Q> { public BackendReadOnlyCdRomsResource(Class<Q> entityType, Guid parentId, VdcQueryType queryType, VdcQueryParametersBase queryParams) { super(CdRom.class, CdRoms.class, entityType, parentId, queryType, queryParams); diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java index 55da5c9..1aae118 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java @@ -6,16 +6,13 @@ import org.ovirt.engine.api.model.Disks; import org.ovirt.engine.api.model.StorageDomain; import org.ovirt.engine.api.model.StorageDomains; -import org.ovirt.engine.api.resource.ReadOnlyDevicesResource; - import org.ovirt.engine.core.common.queries.GetStorageDomainsByVmTemplateIdQueryParameters; import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; import org.ovirt.engine.core.common.queries.VdcQueryType; import org.ovirt.engine.core.compat.Guid; public class BackendReadOnlyDisksResource - extends AbstractBackendReadOnlyDevicesResource<Disk, Disks, org.ovirt.engine.core.common.businessentities.Disk> - implements ReadOnlyDevicesResource<Disk, Disks> { + extends AbstractBackendReadOnlyDevicesResource<Disk, Disks, org.ovirt.engine.core.common.businessentities.Disk> { public BackendReadOnlyDisksResource(Guid parentId, VdcQueryType queryType, VdcQueryParametersBase queryParams) { super(Disk.class, Disks.class, org.ovirt.engine.core.common.businessentities.Disk.class, parentId, queryType, queryParams); diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java index bbe6c3c..5088098 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java @@ -2,15 +2,13 @@ import org.ovirt.engine.api.model.NIC; import org.ovirt.engine.api.model.Nics; -import org.ovirt.engine.api.resource.ReadOnlyDevicesResource; import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface; import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; import org.ovirt.engine.core.common.queries.VdcQueryType; import org.ovirt.engine.core.compat.Guid; public class BackendReadOnlyNicsResource - extends AbstractBackendReadOnlyDevicesResource<NIC, Nics, VmNetworkInterface> - implements ReadOnlyDevicesResource<NIC, Nics> { + extends AbstractBackendReadOnlyDevicesResource<NIC, Nics, VmNetworkInterface> { public BackendReadOnlyNicsResource(Guid parentId, VdcQueryType queryType, VdcQueryParametersBase queryParams) { super(NIC.class, Nics.class, VmNetworkInterface.class, parentId, queryType, queryParams); -- To view, visit http://gerrit.ovirt.org/12535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0388f7941e845d722fd26486a27fe35880792aa3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
