Lior Vernia has posted comments on this change.
Change subject: webadmin: Fixed NIC sorting in Setup Networks popup
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 557: Map<String, VdsNetworkInterface> physicalNics = new
HashMap<String, VdsNetworkInterface>();
Line 558: Map<String, List<String>> bondToNic = new HashMap<String,
List<String>>();
Line 559: Map<String, List<String>> nicToNetwork = new HashMap<String,
List<String>>();
Line 560:
Line 561: Collections.sort(allNics, new
Comparator<VdsNetworkInterface>() {
You are correct, but using SortedSet would cause a lot of breakage, some
careful refactoring needs to be done beforehand. I suggest we make do with the
current solution at the moment, which does fix the bug and doesn't make the
performance worse than before (even though it's not as good as possible).
Line 562:
Line 563: private LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 564:
Line 565: @Override
--
To view, visit http://gerrit.ovirt.org/12149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39928e5c56d110c9c36694e4fc78a2c943023961
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
