Lior Vernia has posted comments on this change.
Change subject: webadmin: Fixed network sorting in VM networks popup
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 454: if (hotUpdateSupported) {
Line 455: networks.add(null);
Line 456: }
Line 457:
Line 458: Collections.sort(networks, new Comparator<Network>() {
Good idea in general, but right now will only be used here so I think it's a
bit of an overkill. Should be implemented when we decide to go ahead and set
all of our sorting code straight (such as refactoring to use SortedSet), not as
a bug fix.
Line 459:
Line 460: private LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 461:
Line 462: @Override
--
To view, visit http://gerrit.ovirt.org/12158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf460633674135ba93babb6b0ffa851ca79d4d6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
