Maor Lipchuk has posted comments on this change.

Change subject: core: Remove image when VDSM returns not exist.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
Line 45:                                 getParameters().getStorageDomainId()));
Line 46: 
Line 47:                 setSucceeded(true);
Line 48:             }
Line 49:         } catch (VdcBLLException e) {
Agreed, will be removed from this command.
Line 50:             if (e.getErrorCode() == 
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 51:                 getReturnValue().setFault(new VdcFault(e, 
e.getErrorCode()));
Line 52:                 log.errorFormat("Image {0} does not exist in domain 
{1}.",
Line 53:                         getDiskImage().getId(),


--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to