Daniel Erez has posted comments on this change. Change subject: userportal: Optimization fixes ......................................................................
Patch Set 7: Looks good to me, approved (2 inline comments) .................................................... Commit Message Line 14: Line 15: 3. Removed duplicate code with regard to clearing Line 16: UserPortalItemModel references by moving it to Line 17: IUserPortalListModel (parent class) Line 18: - Fixed issue where if nothing changed the buttons would please fix commit layout on rebase... Line 19: become disabled. Line 20: - Fixed issue where buttons in basic/extended tab were Line 21: unresponsive. Line 22: .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java Line 307: } Line 308: Line 309: return null; Line 310: } Line 311: redundant change -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
