Allon Mureinik has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 165: * @param vmBase
Line 166: * @param isVm
Line 167: * @param devicesDataToUse
Line 168: * @param disks
Line 169: * @param ifaces
Please either document these parameters or remove the @param specs - this
doesn't add any useful information
Line 170: */
Line 171: public static void copyVmDevices(Guid srcId, Guid dstId, VM vm,
VmBase vmBase, boolean isVm, List<VmDevice> devicesDataToUse, List<DiskImage>
disks, List<VmNetworkInterface> ifaces) {
Line 172: Guid id;
Line 173: int diskCount = 0;
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
