Kanagaraj M has posted comments on this change.

Change subject: webadmin: check up server in gluster cluster guide me
......................................................................


Patch Set 2: (3 inline comments)

Incorporated the comments, please review it.

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 121:                 }), dataCenter.getname());
Line 122:     }
Line 123: 
Line 124:     private void UpdateOptionsNonLocalFS() {
Line 125:         if (hosts == null || allHosts == null || 
(getEntity().supportsGlusterService() && isAnyHostUpInCluster == null)) {
Done
Line 126:             return;
Line 127:         }
Line 128: 
Line 129:         // Add host action.


Line 138:         {
Line 139:             addHostAction.setTitle(ClusterConfigureHostsAction);
Line 140:             getCompulsoryActions().add(addHostAction);
Line 141:         }
Line 142:         else if (!getEntity().supportsGlusterService() || 
isAnyHostUpInCluster)
Done
Line 143:         {
Line 144:             addHostAction.setTitle(ClusterAddAnotherHostAction);
Line 145:             getOptionalActions().add(addHostAction);
Line 146:         }


Line 173:             {
Line 174:                 selectHostAction.setTitle(SelectHostsAction);
Line 175:                 getCompulsoryActions().add(selectHostAction);
Line 176:             }
Line 177:             else if (!getEntity().supportsGlusterService() || 
isAnyHostUpInCluster)
Done
Line 178:             {
Line 179:                 selectHostAction.setTitle(SelectHostsAction);
Line 180:                 getOptionalActions().add(selectHostAction);
Line 181:             }


--
To view, visit http://gerrit.ovirt.org/12050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cea3a3c2a64eca78740d921680faeeb0c5473c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to