Michael Kublin has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 360: for (VM vm : _vmDict.values()) {
Line 361: if (vm.isRunning() && vm.getStatus() != VMStatus.Up) {
Line 362: runningVmsInTransition++;
Line 363: }
Line 364: }
Sorry , we can not continue to work in such way. Cyclic references should stop
to be used and why it used.
VdsManager creates VdsUpdateRuntimeInfo, VdsUpdateRunTimeInfo creates
VmRepositoryUpdater.
VdsUpdateRuntimeInfo points on VdsManger and VmRepositoryUpdater.
VdsManger points on VdsUpdateRunTimeInfo.
VmRepositoryUpdater points on VdsManger.
The split is not good, more objects created, more references is kept, more
difficult to debug
Line 365: vmRepoUpdater = new VmRepositoryUpdater(vdsManager);
Line 366: }
Line 367:
Line 368: protected MonitoringStrategy getMonitoringStrategyForVds(VDS vds)
{
--
To view, visit http://gerrit.ovirt.org/12272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If21db9429413dd8578642b9c09418264a0397aba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
