Ofer Schreiber has posted comments on this change.

Change subject: packaging: Creating keystore for jboss use
......................................................................


Patch Set 1: (1 inline comment)

Code looks good to me.
Why don't we use the "engine" keys we already have?

....................................................
Commit Message
Line 3: AuthorDate: 2013-02-24 13:58:27 +0200
Line 4: Commit:     Alex Lourie <alou...@redhat.com>
Line 5: CommitDate: 2013-02-24 13:58:27 +0200
Line 6: 
Line 7: packaging: Creating keystore for jboss use
should be "create" (or even better - "packaging: engine-setup - create keystore 
for JBoss"
Line 8: 
Line 9: Currently jboss uses apache.p12 keystore file. In cases
Line 10: where apache is not used for proxying, jboss tries to
Line 11: use this file directly and fails on permissions.


--
To view, visit http://gerrit.ovirt.org/12374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d71d9de011e8af4bde26d9e2a048a6387ce70f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to