Gilad Chaplik has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java Line 211: return (ObjectUtils.objectsEqual(quotaId, other.quotaId) Line 212: && ObjectUtils.objectsEqual(quotaVdsGroupId, other.quotaVdsGroupId) Line 213: && ObjectUtils.objectsEqual(vdsGroupId, other.vdsGroupId) Line 214: && ObjectUtils.objectsEqual(virtualCpu, other.virtualCpu) Line 215: && ObjectUtils.objectsEqual(memSizeMB, other.memSizeMB)); I disagree, but I don't mind if it gets done here or in a separate patch. I think that another patch + review + merge is redundant, we can include it in this patch and mention it in the commit msg. After all we're already here :-) I have more reasons but it may be a long discussion :-) and I gave +1 anyway. Line 216: } Line 217: Line 218: /** Line 219: * @return the quotaVdsGroupId -- To view, visit http://gerrit.ovirt.org/12343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I494d81543f001e0c092ef5c9d08f1ded162cac07 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
