Omer Frenkel has posted comments on this change.
Change subject: userportal: quota permissions show extended view wrongfully
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
Line 34:
Line 35: public class UserPortalLoginModel extends LoginModel
Line 36: {
Line 37:
Line 38: private static final int ConsumeQuotaActionGroup = 901;
i dont see a reason for hard coding this here, you should use the actionGroup
enum
Line 39: private UICommand privateChangePasswordCommand;
Line 40:
Line 41: public UICommand getChangePasswordCommand()
Line 42: {
--
To view, visit http://gerrit.ovirt.org/12008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I435bf61277bb77fd4e400ee738b74f71024f57d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
