Michael Kublin has posted comments on this change. Change subject: core: create a data structure for all Runtime updates logics ......................................................................
Patch Set 1: I would prefer that you didn't submit this I am not agree with concept. The code was not improve, a new wrapper is created, all messed code is moved from one place to another - I don't see any improvements in hiding a mess that I have (imo). Why I need a shared class for VdsManager and VdsRuntine, when VdsRuntimeInfo is created in VdsManager and after that VdsRuntimeInfo is point on VdsManager, this is problem. Creating a new class that VdsManager and VdsRuntimeInfo all together will point on it - it is not solution. -- To view, visit http://gerrit.ovirt.org/12273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I434b1429dfa184f7a8212843ad7ee2c5a196c783 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
