Allon Mureinik has uploaded a new change for review.
Change subject: ui: Simplify keySelected eval in KeyValueModel
......................................................................
ui: Simplify keySelected eval in KeyValueModel
Simplify the evaluation of eventRaised()'s keySelected variable in
KeyValueModel - listModel's getSelectedItem() is called a couple of
rows beforehand, so it is clearly not null.
Change-Id: I2a27e4e18774775c12b7f824a9b5c5a433397a3a
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/12331/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
index 449ca35..88ccf9c 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
@@ -40,7 +40,7 @@
if (listModel.getSelectedItem() != null) {
key = (String) listModel.getSelectedItem();
}
- boolean keySelected = listModel != null &&
+ boolean keySelected =
key != null &&
!key.equals(KeyValueModel.SELECT_KEY) &&
!key.equals(KeyValueModel.NO_KEYS);
--
To view, visit http://gerrit.ovirt.org/12331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a27e4e18774775c12b7f824a9b5c5a433397a3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
