Allon Mureinik has posted comments on this change. Change subject: core: Add message when template does not exists. ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) See my suggestion on the commit message .................................................... Commit Message Line 6: Line 7: core: Add message when template does not exists. Line 8: Line 9: If template does not exists when it is being edited we should return a Line 10: CDA message which implies it. How about just rewriting this entire message? "Return a proper CDA message when attempting to ediit a non-existent template." Line 11: Line 12: Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c -- To view, visit http://gerrit.ovirt.org/10847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
