Alissa Bonas has posted comments on this change.
Change subject: core: Remove PropertyCompat
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java
Line 17: private String someValue = "Anakin";
Line 18:
Line 19: @Test
Line 20: public void testIt() {
Line 21: PropertyInfo pc = TypeCompat.GetProperty(this.getClass(),
"someValue");
I'd also change the variable name - it was pc because of PropertyCompat, now it
looks weird because of new class name. I'd go with propertyInfo but that's
just a suggestion.
Line 22: String result = (String) pc.GetValue(this, "JarJar");
Line 23: assertEquals("Standard", "Anakin", result);
Line 24: this.someValue = null;
Line 25: result = (String) pc.GetValue(this, "JarJar");
--
To view, visit http://gerrit.ovirt.org/12257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
