Michael Kublin has posted comments on this change.
Change subject: core: Clean "only in db" async tasks
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 549:
Line 550: List<AsyncTasks> tasksInDForStoragePool =
tasksInDbAfterRestart.get(sp.getId());
Line 551: if (tasksInDForStoragePool != null) {
Line 552: for (AsyncTasks task : tasksInDForStoragePool) {
Line 553: if (!_tasks.containsKey(task.gettask_id())) {
Just small remark, or move this code under synchronized or make _tasks
ConcurrentHashMap, because of _tasks is shared variable and contains is not
synchronized
Line 554:
DbFacade.getInstance().getAsyncTaskDao().remove(task.gettask_id());
Line 555: }
Line 556: }
Line 557: }
--
To view, visit http://gerrit.ovirt.org/12055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
