Allon Mureinik has posted comments on this change.
Change subject: core: VmRunHandler: correct check for disk images
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 127: ValidationResult spUpResult = new
StoragePoolValidator(sp).isUp();
Line 128: if (!spUpResult.isValid()) {
Line 129:
message.add(spUpResult.getMessage().name());
Line 130: retValue = false;
Line 131: }
1. This behaviour exists before the patch too - I agree it's probably a bug,
but let's not mix two fixes in the same patch.
I'll send a patch to move it out of this block.
2. The idea is to avoid this flow altogether if the VM does have any IMAGE
disks. The price we pay (in the meanwhile, until we finish breaking up
PerformImageChecks - patch pending `-)) is to do two iterations on a list that
has up to 26 elements. No biggie, IMHO.
Line 132:
Line 133: if (retValue &&
!performImageChecksForRunningVm(vm, message, runParams, vmImages)) {
Line 134: retValue = false;
Line 135: }
--
To view, visit http://gerrit.ovirt.org/12247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47cf77154a5e46af23a10550884bbd6cdeecb30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
