Sahina Bose has posted comments on this change.

Change subject: core: Add GlusterFS support to AsyncDataProvider
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 2664: 
Line 2665:     public static boolean IsVersionMatchStorageType(Version version, 
StorageType type)
Line 2666:     {
Line 2667:         return !((type == StorageType.LOCALFS && 
version.compareTo(new Version(2, 2)) <= 0)
Line 2668:                || (type == StorageType.POSIXFS && 
version.compareTo(new Version(3, 0)) <= 0)
Config file has GLUSTERFS storage enabled in 3.3, should this be changed here 
too?
Line 2669:                || (type == StorageType.GLUSTERFS && 
version.compareTo(new Version(3, 2)) <= 0));
Line 2670:     }
Line 2671: 
Line 2672:     public static int GetClusterDefaultMemoryOverCommit()


--
To view, visit http://gerrit.ovirt.org/8962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b4a90f714eeef404e75a2bae0cdd08f69bb12a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to