Sahina Bose has posted comments on this change.
Change subject: engine: Gluster hook content query
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java
Line 5:
Line 6: /**
Line 7: * Parameter class with Gluster Hook Id as parameters. <br>
Line 8: * This will be used by Gluster Hook Content query. <br>
Line 9: */
How about host id as a parameter? How do we retrieve the hook script for a
specific host in cluster?
Line 10: public class GlusterHookQueryParameters extends VdcQueryParametersBase
{
Line 11: private static final long serialVersionUID = 4564573475511998657L;
Line 12:
Line 13: private Guid glusterHookId;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java
Line 88: entity.setStatus(glusterServerHook.getStatus());
Line 89: }
Line 90: return entity;
Line 91: }
Line 92:
Will there be a check for binary content type? Will null be returned in this
case?
Line 93: @Override
Line 94: public String getGlusterHookcontent(Guid hookId) {
Line 95: String content =
getCallsHandler().executeRead("GetGlusterHookById", GlusterHookContentRowMapper,
Line 96: createGlusterHookIdParams(hookId));
--
To view, visit http://gerrit.ovirt.org/12219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24d1132fc214661cd2c2e3071f641812d19cd4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
