Allon Mureinik has uploaded a new change for review.

Change subject: build: NlsCheck - proper inner class
......................................................................

build: NlsCheck - proper inner class

Made the inner class QuotedString private static, as it is not used
outside this class and does not require access to the enclosing class'
members.

Also removed the redundant semicolon at the end of the declaration.

Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/12251/1

diff --git 
a/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
 
b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
index c60e40d..b999292 100644
--- 
a/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
+++ 
b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
@@ -125,7 +125,7 @@
         return -1;
     }
 
-    class QuotedString {
+    private static class QuotedString {
         String text;
         int startIndex;
         int endIndex;
@@ -135,7 +135,7 @@
             this.startIndex = startIndex;
             this.endIndex = endIndex;
         }
-    };
+    }
 
     public void setRun(boolean run) {
         this.run = run;


--
To view, visit http://gerrit.ovirt.org/12251
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to