Roy Golan has posted comments on this change.
Change subject: core: patterned pool names support
......................................................................
Patch Set 5: (1 inline comment)
didn't think you'd go for it in the endr
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NameForVmInPoolGeneratorTest.java
Line 3:
Line 4: import org.junit.Test;
Line 5: import org.ovirt.engine.core.common.businessentities.VmPool;
Line 6:
Line 7: public class NameForVmInPoolGeneratorTest {
nice and clean!
Line 8:
Line 9: @Test
Line 10: public void validateGenerateVmNameStartsWithMask() {
Line 11: assertEquals("017mypool",
NameForVmInPoolGenerator.generateVmName("???mypool".replace('?',
VmPool.MASK_CHARACTER), 17));
--
To view, visit http://gerrit.ovirt.org/11986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a1ffb6324fb728b2584677dd654ac79b679cd8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
