Juan Hernandez has posted comments on this change. Change subject: userportal, webadmin: Added caching ......................................................................
Patch Set 12: I still get the following errors when trying to build after applying this patch: [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[24,32] error: package com.google.gwt.rpc.server does not exist [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[26,46] error: cannot find symbol [ERROR] class RpcServlet /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[26,7] error: cannot access RpcService [ERROR] class file for com.google.gwt.rpc.client.RpcService not found /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[40,8] error: cannot find symbol [ERROR] class GenericApiGWTServiceImpl /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[47,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[52,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[60,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[67,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[99,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[114,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[130,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[151,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[159,4] error: method does not override or implement a method from a supertype [ERROR] /files/projects/ovirt/repository/frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:[169,37] error: cannot find symbol These errors happen because of the missing dependencies in the frontend/webadmin/modules/frontend-overlay/pom.xml (see the inline comments). I don't have anything about using web fragments, that is ok, what I would like is to avoid having an additional .jar file, as we can have almost all what we have in frontend-overlay.jar in frontend.jar instead. Alex, I probably understood incorrectly what you wrote, but I believe that frontend-overyay.jar is not merged into the main war during build, it is just another .jar file inside WEB-INF/lib and the contents of both are "merged" during runtime by the application server. What I propose is to use the already existing frontend.jar in the same way, just to avoid one additional .jar file, as this complicates packaging (only a bit, not a big deal). I also wonder why we can't put the classes and servlet definitions that are specific to user portal or webadmin in their own .war and web.xml files. All these, except the compilation errors, are minor issues, or maybe just my personal quirks. I will +1 once the build works correctly. -- To view, visit http://gerrit.ovirt.org/10449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d8e02ae542a4aa37bd421bde5582c0f3e9820ad Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
