Gilad Chaplik has posted comments on this change.

Change subject: webadmin: check UP server before adding bricks
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 1130:         aQuery.converterCallback = new IAsyncConverter() {
Line 1131:             @Override
Line 1132:             public Object Convert(Object source, AsyncQuery 
_asyncQuery)
Line 1133:             {
Line 1134:                 if (source != null) {
consider changing to: return source != null;
Line 1135:                     return true;
Line 1136:                 }
Line 1137:                 else {
Line 1138:                     return false;


--
To view, visit http://gerrit.ovirt.org/11927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b3c0eacbe4c94929d20738196324569ed8f3b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to