Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add storage space validation to removeSnapshot ......................................................................
core: Add storage space validation to removeSnapshot Today there is no validation in RemoveSnapshotCommand to ensure there is enough space on the domain to merge the disk snapshots. This space is needed on remove snapshot process since VDSM creates a new temporary volume, as part of the merge process, which might be large as the volume's actual size. The proposed fix introduces a new validation in the command which validates whether each storage domain has enough free space to perform removeSnapshot. Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9 Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 4 files changed, 217 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
