Vered Volansky has posted comments on this change. Change subject: core: Cleanup of GetSystemStatisticsQuery ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java Line 37: int totalHosts = getTotalHostsStat(); Line 38: int activeHosts = getActiveHostsStat(); Line 39: int maintenanceHosts = getMaintenanceHostsStat(); Line 40: int downHosts = Line 41: (totalHosts - activeHosts - maintenanceHosts) < 0 ? 0 : (totalHosts - activeHosts - maintenanceHosts); That's a bit long. I'd assign first and ? : after on the left parameter. Just a suggestion. Line 42: Line 43: // Users: Line 44: int totalUsers = getTotalUsersStat(); Line 45: int activeUsers = getActiveUsersStat(); -- To view, visit http://gerrit.ovirt.org/12145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
