Liron Aravot has posted comments on this change. Change subject: core: RemoveVm CDA for LUN disks optimization ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 153: return false; Line 154: } Line 155: Line 156: Collection<Disk> vmDisks = getVm().getDiskMap().values(); Line 157: List<DiskImage> vmImages = ImagesHandler.filterImageDisks(vmDisks, true, false); won't we filter the disk's filtered twice now? i'd suggest somehow avoid it Line 158: if (!vmImages.isEmpty() && !ImagesHandler.PerformImagesChecks( Line 159: getReturnValue().getCanDoActionMessages(), Line 160: getVm().getStoragePoolId(), Line 161: Guid.Empty, -- To view, visit http://gerrit.ovirt.org/12144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6ebb5d3d5b23075424acc92a616f2d7e338170 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
